Skip to content

Commit

Permalink
Merge pull request #3 from juan-ayala/feature/aem-template-updates
Browse files Browse the repository at this point in the history
[aem] minor updates to template
  • Loading branch information
juan-ayala authored Aug 8, 2024
2 parents 3cb6264 + d0ea084 commit 1cd01bd
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 47 deletions.
2 changes: 2 additions & 0 deletions src/aem/.devcontainer/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# AEM SDK zip files
aem-sdk-*.zip
2 changes: 2 additions & 0 deletions src/aem/.devcontainer/AEM-SDK.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# AEM SDK
Download the AEM SDK from Adobe's [software distribution site](https://experience.adobe.com/#/downloads). Place it in this directory. It should not get checked into source control. Then run the `start-aem <service>` command in the dev container.
29 changes: 7 additions & 22 deletions src/aem/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,30 +15,15 @@
"version": "11",
"installMaven": true
},
"ghcr.io/juan-ayala/devcontainer-features/aem-sdk:1": {
"sdksDirectory": "${templateOption:sdksDirectory}",
"sdkVersion": "${templateOption:sdkVersion}",
"authorPort": "${templateOption:authorPort}",
"publishPort": "${templateOption:publishPort}",
"dispatcherPort": "${templateOption:dispatcherPort}"
}
"ghcr.io/juan-ayala/devcontainer-features/aem-sdk:1": {}
},

// 👇 Use 'forwardPorts' to make a list of ports inside the container available locally.
"forwardPorts": [
"${templateOption:authorPort}",
"3${templateOption:authorPort}",
"${templateOption:publishPort}",
"3${templateOption:publishPort}",
"${templateOption:dispatcherPort}"
],

// 👇 Configure tool-specific properties.
"customizations": {
"vscode": {
"settings": {
"java.compile.nullAnalysis.mode": "automatic"
}
}
}
4502,
34502,
4503,
34503,
8080
]
}
25 changes: 0 additions & 25 deletions src/aem/devcontainer-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,31 +19,6 @@
"type": "string",
"description": "Node.js version to install.",
"default": "12.22.7"
},
"sdksDirectory": {
"type": "string",
"description": "Path to directory that contains one or more SDKs. This should be relative to the container workspace folder.",
"default": ".devcontainer"
},
"sdkVersion": {
"type": "string",
"description": "AEM SDK Version that will be retreived from the SDKs directory.",
"default": "automatic"
},
"authorPort": {
"type": "string",
"description": "Author service port",
"default": "4502"
},
"publishPort": {
"type": "string",
"description": "Publish service port",
"default": "4503"
},
"dispatcherPort": {
"type": "string",
"description": "Dispatcher port",
"default": "8080"
}
},
"platforms": [
Expand Down

0 comments on commit 1cd01bd

Please sign in to comment.