Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow to lookup Node by its Tailnet IP address in GRPC API #2237

Open
1 of 2 tasks
jirutka opened this issue Nov 15, 2024 · 2 comments
Open
1 of 2 tasks

[Feature] Allow to lookup Node by its Tailnet IP address in GRPC API #2237

jirutka opened this issue Nov 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jirutka
Copy link

jirutka commented Nov 15, 2024

Use case

For monitoring purposes, it’s necessary to find out to which node and user a given IP address belongs.

Description

.

Contribution

  • I can write the design doc for this feature
  • I can contribute this feature

How can it be implemented?

a. Change GetNodeRequest to oneof node_id or tailnet_ip. If tailnet_ip is provided, lookup Node by its IPv4 or IPv6 address.
b. Add a new method, e.g. GetNodeByIp.

@jirutka jirutka added the enhancement New feature or request label Nov 15, 2024
@kradalby
Copy link
Collaborator

Sounds reasonable to me, maybe make it reasonable generic and tap into the "list" version so we can do id, name, ip etc?

@kradalby
Copy link
Collaborator

I started look at this based while working on #2246 and it looks like our usage of the grpc web api generator we use prevents us from using oneof: grpc-ecosystem/grpc-gateway#441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants