WavPack decoding support #168
Conversation
|
|
||
| namespace WavPackNamespace | ||
| { | ||
| #include <wavpack/wavpack.h> |
There was a problem hiding this comment.
I think in true JUCE fashion wavpack's files would be added locally to the module.
There was a problem hiding this comment.
Yes, we don't generally include 3rd party headers unless really necessary. What is in wavpack.h and where would someone get it? Does it rely on a static library to go with it, or is it header only?
There was a problem hiding this comment.
Looks like you can directly get the source: http://www.wavpack.com/downloads.html#sources
Alternatively, you could add a git submodule for its (official?) repository: https://github.com/dbry/WavPack
|
I've included Wavpack source, only needed files, fixed warnings, and conversion errors. |
|
Was curious, so ran the code on VS2013 and VS2015 - no warnings, which is good! Problem is that I can't find any files to test with. I guess this format is a bit niche? |
|
You're right, it is a bit niche (actually I am writing music player in JUCE so I want to support all formats). I think the easiest way to test it is to download converter (there is one in wavpacks site) and convert some audio to wv. |
|
Thanks. I got a file converted using all sorts of different WavPack settings and they all played back just fine. |
|
@c41x I'd be keen on using this in our application for similar reasons. Have you mentioned this PR on the forums? Could be good timing with JUCE 5... |
|
@jrlanglois Nope, I'm not registered on JUCE forums... If you write audio player you could use my FFmpeg decoder for JUCE (https://github.com/c41x/JUCE-FFmpeg) :) |
|
@c41x I suggest you post that FFMPEG reader support on the forums - I think it will get a decent amount of attention! |
|
@c41x I'm not so sure about the wavpack reader code after testing this with wavpack's provided test suite. |
|
Also, the sample rates supported by WavPack are as follows: 6000, 8000, 9600, 11025, 12000, 16000, 22050, 24000,
32000, 44100, 48000, 64000, 88200, 96000, 192000You've only listed a subset, and some incorrect rates: 8000, 11025, 12000, 16000, 22050, 32000,
44100, 48000, 88200, 96000, 176400, 192000 |
As in title.