Better environment control when spawning processes (develop) #832
Conversation
kunitoki
changed the title
| @@ -445,15 +482,15 @@ class ChildProcess::ActiveProcess | |||
|
|
|||
| if (available == 0) | |||
| { | |||
| if (! isRunning()) | |||
| if (total != 0 || ! isRunning()) | |||
There was a problem hiding this comment.
this is to produce the output faster on windows and avoid spinning if we alread have characters. this will make the shell output flow more fluently instead of getting out very slow and clunky on processes that produce lot of output (like build systems).
| Thread::sleep (1); | ||
| } | ||
| else | ||
| { | ||
| DWORD numRead = 0; | ||
| if (! ReadFile ((HANDLE) readPipe, dest, (DWORD) numToDo, &numRead, nullptr)) | ||
| if (! ReadFile ((HANDLE) readPipe, dest, (DWORD) numToDo, &numRead, nullptr) || numRead == 0) |
| auto oldEnvironment = SystemStats::getEnvironmentVariables(); | ||
| for (const auto& key : oldEnvironment.getAllKeys()) | ||
| SystemStats::removeEnvironmentVariable (key); | ||
|
|
||
| for (const auto& key : environment.getAllKeys()) | ||
| SystemStats::setEnvironmentVariable (key, environment.getValue (key, {})); | ||
|
|
||
| HINSTANCE hInstance = ShellExecute (0, 0, fileName.toWideCharPointer(), | ||
| parameters.toWideCharPointer(), 0, SW_SHOWDEFAULT); | ||
|
|
||
| for (const auto& key : environment.getAllKeys()) | ||
| SystemStats::removeEnvironmentVariable (key); | ||
|
|
||
| for (const auto& key : oldEnvironment.getAllKeys()) | ||
| SystemStats::setEnvironmentVariable (key, oldEnvironment.getValue (key, {})); |
There was a problem hiding this comment.
unluckily ShellExecute inherit the environment and it doesn't allow to specify a custom environment like execve, so i had to modify the env in place
| #endif | ||
|
|
||
| if (readHandle == nullptr && childPID != 0) | ||
| readHandle = fdopen (pipeHandle, "r"); |
There was a problem hiding this comment.
by not doing this we can use use non buffering and non blocking read instead of fread which can block the process if no output is produced. speed is improved and you won't get character out in chunks with lot of latency and wait time between buffer are filled with new data. it is especially noticeable if you trigger cmake with lots of output from a juce ChildProcess.
|
@tpoole thanks for pointing out the PR i made on juce6 has been closed automatically. Any chance these changes will be considered ? |
Add support for better environment variables in the framework, because since today it was not possible to start a process and control which environment should have:
SystemStatsto allow getting and changing the environment:ChildProcessto pass the environment variables the child process should retain:Processto pass the environment variables the process spawned should retain:Process::openDocumentto correctly spawn .app bundles with arguments and environment, and well as urls and local files.