Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle method w/o return values #7

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Handle method w/o return values #7

merged 2 commits into from
Jul 29, 2024

Conversation

zeenix
Copy link
Member

@zeenix zeenix commented Jul 29, 2024

Currently the macro is unable to handle methods that don't return anything. This PR fixes that.

@zeenix zeenix requested review from kkrolczyk and maxgr0 July 29, 2024 10:33
kkrolczyk
kkrolczyk approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@kkrolczyk kkrolczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested & works

maxgr0
maxgr0 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@maxgr0 maxgr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kkrolczyk kkrolczyk merged commit b4e0d76 into main Jul 29, 2024
3 checks passed
@kkrolczyk kkrolczyk deleted the method-no-return-val branch July 29, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxgr0 maxgr0 maxgr0 approved these changes

@kkrolczyk kkrolczyk kkrolczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeenix @kkrolczyk @maxgr0