Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed to using Procfile #13

Closed
wants to merge 1 commit into from
Closed

Conversation

rage311
Copy link

@rage311 rage311 commented Nov 8, 2017

I think this resolves #2

The Perloku file is still used in the detect script to verify that the perloku buildpack should be applied, but it is moved to Procfile in the $BUILD_DIR when it's done compiling.

@judofyr
Copy link
Owner

judofyr commented Nov 9, 2017

I haven't updated this in a while so I'm not sure if this is correct either. Do you use Perloku in production or anything?

@rage311
Copy link
Author

rage311 commented Nov 9, 2017

To be honest, I've just gotten started with Heroku. I'm reviving the Net::Heroku module, as well as Mojolicious::Command::deploy::heroku. I've tested this Procfile change with a couple of small projects, and Heroku picks up the "web: .." dyno process definition when it gets deployed. I dug through the Heroku docs for the Buildpack API (https://devcenter.heroku.com/articles/buildpack-api) to be as certain as possible that I was doing it right, and it IS working. I'll look into a couple other buildpacks to get some confirmation though.

Also, I should squash those commits into one... whoops.

@judofyr
Copy link
Owner

judofyr commented Nov 10, 2017

I haven't been following the Perl web community in the last few years so I don't know exactly what needs to be tweaked. We should probably upgrade the Perl version for instance.

@rage311
Copy link
Author

rage311 commented May 4, 2018

6 months later, I'm back at working on this...

I squashed all the previous commits into one.

What's required to change to using the latest version of Perl (5.26.2)? I see the bin/compile file references a tgz on perloku.s3.amazonaws.com, but the support/build_perl file looks like it uses perlbrew to build a Perl binary. What's necessary here?

@judofyr
Copy link
Owner

judofyr commented May 8, 2018

I'm not sure how the flow for writing buildpacks are these days, but previously you used the vulcan-tool (see support/build_perl) to build tools in the correct environment. That gives you a tgz that you can extract into a Heroku build and everything will just work. I manually uploaded the tgz to the S3 bucket under my control.

I guess the next steps are:

  • Figuring out if vulcan is still the way to build tools
  • Checking if perlbrew is the best way to continue building the interpreter
  • Checking if it builds correctly
  • Uploading the tgz somewhere and see that everything works as usual
  • If everything works: Upload tgz to S3, bump version in bin/compile

@rage311
Copy link
Author

rage311 commented May 22, 2018

Thanks for the info. I think I've still got some work to do to figure out how to modernize this stack correctly. Apparently vulcan is deprecated, for one.

@rage311 rage311 closed this May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to Procfile instead of Perloku file
2 participants