Remove axum-test dependency
#1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `axum-test` crate has not yet been updated to work with axum v0.8 and is blocking us from releasing support for it ourselves. Since we use very little functionality from it, we can just replace it with direct calls to the `ServiceExt` trait of `tower`.
Turbo87
force-pushed
the
remove-axum-test
branch
from
12d3bcd to
9c2c637
Compare
juhaku
reviewed
Jan 2, 2025
|
it's only used internally though, so not sure how useful it is for users of the library to know 😅 |
|
Yup, valid point, wondering the same, it does not change how the lib is used in anyways, and if they want to see they have access to full changelog anyway from the release, so they can find it, it is just bit more effort. |
|
Of we go with the merge. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
axum-testcrate has not yet been updated to work with axum v0.8 and is blocking us from releasing support for it ourselves. Since we use very little functionality from it, we can just replace it with direct calls to theServiceExttrait oftower.This should unblock #1269