fix dashboard remote terminal leak #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxh326
force-pushed
the
fix-remote-terminal-leak
branch
from
f386c70
to
9d6c9fc
Compare
zxh326
force-pushed
the
fix-remote-terminal-leak
branch
2 times, most recently
from
32adf84
to
11216c7
Compare
Signed-off-by: Xuhui zhang <[email protected]>
zxh326
force-pushed
the
fix-remote-terminal-leak
branch
from
11216c7
to
e5c5a1c
Compare
zwwhdls
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need send
ctrl+d/cto close remote terminal when receive EOF or other errorref: kubernetes/client-go#554
ref: https://github.com/kubernetes/dashboard/blob/4eda6647c3f6c697dbe40c20d7bb8ba96fecd4e7/modules/api/pkg/handler/terminal.go#L83-L84