Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vci serverless #753

Merged
merged 11 commits into from
Oct 13, 2023
Merged

support vci serverless #753

merged 11 commits into from
Oct 13, 2023

Conversation

zwwhdls
Copy link
Member

@zwwhdls zwwhdls commented Sep 18, 2023

  1. when in serverless environment, do not mount hostPath except mount point. Set juicefs.com/enable-serverless-injection: "true" in namespace to use.
  2. support VCI serverless. Set juicefs.com/enable-serverless-injection: "true" in namespace and vke.volcengine.com/burst-to-vci: enfore in pod to use.
    • do not mount hostPath
    • container is not privileged
    • no propagationBidirectional mountPropagation
    • no initContainer
    • with env JFS_NO_UMOUNT=1
    • annotations for VCI

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Attention: 354 lines in your changes are missing coverage. Please review.

Comparison is base (eb067a3) 37.99% compared to head (9992903) 36.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
- Coverage   37.99%   36.62%   -1.37%     
==========================================
  Files          34       36       +2     
  Lines        4135     4306     +171     
==========================================
+ Hits         1571     1577       +6     
- Misses       2412     2582     +170     
+ Partials      152      147       -5     
Files Coverage Δ
pkg/juicefs/mount/builder/secret.go 0.00% <ø> (ø)
pkg/util/util.go 32.82% <100.00%> (+0.68%) ⬆️
pkg/driver/controller.go 60.00% <0.00%> (-0.84%) ⬇️
pkg/juicefs/mount/pod_mount.go 34.44% <25.00%> (ø)
pkg/driver/provisioner.go 8.59% <0.00%> (-0.35%) ⬇️
pkg/juicefs/mount/builder/job.go 0.00% <0.00%> (ø)
pkg/webhook/handler/mutate/sidecar.go 20.49% <19.23%> (-4.51%) ⬇️
pkg/juicefs/mount/builder/pod.go 63.63% <59.00%> (+10.69%) ⬆️
pkg/juicefs/mount/builder/common.go 58.75% <67.66%> (+11.49%) ⬆️
pkg/juicefs/mount/builder/container.go 0.00% <0.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
…Container only if need to create subpath

Signed-off-by: zwwhdls <[email protected]>
Copy link
Contributor

@Hexilee Hexilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zwwhdls zwwhdls merged commit 4106e83 into master Oct 13, 2023
23 checks passed
@zwwhdls zwwhdls deleted the fix/sidecar_in_serverless branch October 13, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants