fix delete volume issues #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuhui zhang <[email protected]>
Signed-off-by: Xuhui zhang <[email protected]>
zxh326
force-pushed
the
fix-delete-volume-job
branch
from
9c6b4d9
to
8ae68fb
Compare
timfeirg
reviewed
Apr 25, 2024
zxh326
commented
Apr 26, 2024
| // set node name to empty to let k8s scheduler to choose a node | ||
| podTemplate.Spec.NodeName = "" | ||
| // set priority class name to empty to make job use default priority class | ||
| podTemplate.Spec.PriorityClassName = "" |
There was a problem hiding this comment.
large number of cleanup/delvol jobs may preempt normal/application pods, which is not as expected
timfeirg
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add locks for delete volume
remove nodeName & priorityClass for job