Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fuse unmount when exit #5064

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

jiefenghuang
Copy link
Contributor

@jiefenghuang jiefenghuang commented Aug 7, 2024

close #5048

Signed-off-by: jiefenghuang <[email protected]>
pkg/fuse/fuse.go Outdated Show resolved Hide resolved
@jiefenghuang jiefenghuang marked this pull request as draft August 7, 2024 07:22
@davies davies requested a review from SandyXSD August 7, 2024 10:02
@jiefenghuang jiefenghuang marked this pull request as ready for review August 8, 2024 07:24
Signed-off-by: jiefenghuang <[email protected]>
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.62%. Comparing base (aab30fa) to head (644eb23).
Report is 5 commits behind head on main.

Files Patch % Lines
pkg/fuse/fuse.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5064       +/-   ##
===========================================
+ Coverage   24.99%   45.62%   +20.63%     
===========================================
  Files          25      159      +134     
  Lines       16047    43347    +27300     
===========================================
+ Hits         4011    19778    +15767     
- Misses      11547    21177     +9630     
- Partials      489     2392     +1903     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiefenghuang jiefenghuang merged commit 97082f1 into juicedata:main Aug 9, 2024
39 checks passed
@jiefenghuang jiefenghuang deleted the fix/umount branch August 9, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MacOS] "device not configured"
3 participants