Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear signal handler when child process exits #5245

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

polyrabbit
Copy link
Contributor

#5238 propagates signals to child process, but provides no way to clear signal handler and exit goroutine.
The child process is started in a loop, unable to clear signal handler causes false positive warning logs.

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 53.95%. Comparing base (c2b21f4) to head (6b58778).
Report is 44 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mount_unix.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5245      +/-   ##
==========================================
- Coverage   54.27%   53.95%   -0.33%     
==========================================
  Files         161      162       +1     
  Lines       43776    44359     +583     
==========================================
+ Hits        23758    23932     +174     
- Misses      17336    17729     +393     
- Partials     2682     2698      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhijian-pro zhijian-pro merged commit ddd82ed into juicedata:main Oct 22, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants