Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

alxhoff
Copy link

@alxhoff alxhoff commented Mar 25, 2020

Just some small observations I made. Cool project, will see if I can find time to contribute.

@@ -394,7 +394,7 @@ Enable the option `#define DISPLAY_ROTATE_180_DEGREES` in `config.h`. This shoul

Edit the file `config.h` in a text editor (a command line one such as `pico`, `vim`, `nano`, or SSH map the drive to your host), and find the appropriate line in the file. Add comment lines `//` in front of that text to disable the option, or remove the `//` characters to enable it.

After having edited and saved the file, reissue `make -j` in the build directory and restart fbcp-ili9341.
After having edited and saved the file, reissue ``make -j `nproc` `` in the build directory and restart fbcp-ili9341.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is make -j not enough to get to parallel compilation? Or does that not work in some cases?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't really know if -j is a problem. The docs say

If there is nothing looking like an integer after the ‘-j’ option, there is no limit on the number of job slots.

What effect that has I don't know, I'm just used to always using nproc.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's go with just make -j then, no need to specify the nproc.

README.md Outdated Show resolved Hide resolved
@alxhoff
Copy link
Author

alxhoff commented Apr 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants