If the user does not specify the optional git_cli input, we should respect any pre-existing value of the JULIA_PKG_USE_CLI_GIT environment variable

[DilumAluthge]

#38 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5484b0e) 100.00% compared to head (a432b34) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[omus]

Suggested change

	INPUT_GIT_CLI_str = strip(ENV["INPUT_GIT_CLI"])
	if isempty(INPUT_GIT_CLI_str)
	# Empty = user did not provide this input = we should do nothing.
	else
	# Non-empty = user provided this input = we enforce that it must be either
	# `true` or `false`.
	INPUT_GIT_CLI_b = parse(Bool, INPUT_GIT_CLI_str)
	ENV["JULIA_PKG_USE_CLI_GIT"] = "$(INPUT_GIT_CLI_b)"
	if (VERSION < v"1.7-") && INPUT_GIT_CLI_b
	printstyled("::notice::JULIA_PKG_USE_CLI_GIT requires Julia >= 1.7. Using default LibGit2 git-interface instead! \n"; color = :yellow)
	end
	git_cli = strip(ENV["INPUT_GIT_CLI"])
	if !isempty(git_cli)
	ENV["JULIA_PKG_USE_CLI_GIT"] = string(git_cli == "true")
	if VERSION < v"1.7-" && git_cli == "true"
	printstyled("::notice::JULIA_PKG_USE_CLI_GIT requires Julia >= 1.7. Using default LibGit2 git-interface instead! \n"; color = :yellow)
	end

Alternatively, if we want to follow the original code's behavior where JULIA_PKG_USE_CLI_GIT is only set in Julia 1.7- and above we can do:

Suggested change

	INPUT_GIT_CLI_str = strip(ENV["INPUT_GIT_CLI"])
	if isempty(INPUT_GIT_CLI_str)
	# Empty = user did not provide this input = we should do nothing.
	else
	# Non-empty = user provided this input = we enforce that it must be either
	# `true` or `false`.
	INPUT_GIT_CLI_b = parse(Bool, INPUT_GIT_CLI_str)
	ENV["JULIA_PKG_USE_CLI_GIT"] = "$(INPUT_GIT_CLI_b)"
	if (VERSION < v"1.7-") && INPUT_GIT_CLI_b
	printstyled("::notice::JULIA_PKG_USE_CLI_GIT requires Julia >= 1.7. Using default LibGit2 git-interface instead! \n"; color = :yellow)
	end
	git_cli = strip(ENV["INPUT_GIT_CLI"])
	if VERSION >= v"1.7-" && !isempty(git_cli)
	ENV["JULIA_PKG_USE_CLI_GIT"] = string(git_cli == "true")
	elseif VERSION < v"1.7-" && git_cli == "true"
	printstyled("::notice::JULIA_PKG_USE_CLI_GIT requires Julia >= 1.7. Using default LibGit2 git-interface instead! \n"; color = :yellow)
	end