Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia registries only when not present #49

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

omus
Copy link
Contributor

@omus omus commented Jan 9, 2024

Working around: JuliaLang/Pkg.jl#3753

@omus omus requested a review from a team as a code owner January 9, 2024 21:19
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90dd6f2) 100.00% compared to head (ad723e2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omus omus force-pushed the cv/add-registry-only-when-missing branch from 29328cd to 3303386 Compare January 10, 2024 20:59
@omus
Copy link
Contributor Author

omus commented Jan 10, 2024

Last commit reduces checks from 42 to 32

@IanButterworth
Copy link
Member

I'm tagging @DilumAluthge for review as he's thought more about the edge cases in registry types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants