Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 190 - use fully qualified names for fixed #191

Merged

Conversation

steve-e
Copy link

@steve-e steve-e commented Jan 5, 2024

Issue 190

  • Implementation of Short term solution
  • Use fully qualified names for fixed types to handle potential name clashes.

@steve-e
Copy link
Author

steve-e commented Jan 5, 2024

Some of the builds here are failing due to different import order for the fixed types. Two solutions I can think of

  • order the imports somewhere (not sure where)
  • do not create imports for fixed types as they are now fully qualified

I prefer the second option, but am not sure if there are cases where the imports are still needed. I think there should not be.

By the way, feel free to reject this PR or make or suggest changes.

@julianpeeters julianpeeters merged commit c1e33bc into julianpeeters:main Jan 6, 2024
3 of 6 checks passed
@julianpeeters
Copy link
Owner

Great stuff.

Agreed, fixed imports have now been removed.

Available now, as avrohugger 2.8.2 and sbt-avrohugger 2.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants