-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve performance and documentation, skip the first 2 events after reconnected #363
base: main
Are you sure you want to change the base?
Conversation
woods-chen
commented
Dec 2, 2021
* symplify BinLogStreamReader.fetchone * improve documentation of BinLogStreamReader * tests/test_data_type.py: fix syntax errors * tests/test_basic.py: dynamic get an end position instead a fixed one
* sleep 5s after disconnected accidently and skip the first 2 events after reconnected * some cleanup and compacting works
@woods-chen However, I'm a little concerned about Nice work with the optimization, but I think we should keep parsing the first |
modified: pymysqlreplication/binlogstream.py
@dongwook-chan |
@woods-chen |
395b5b9
to
c60c70e
Compare