Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: typo in ident variable name #619

Merged

Conversation

fulghum
Copy link
Contributor

@fulghum fulghum commented Jul 26, 2024

Description

The HeartbeatLogEvent::dump method had a typo in the ident var name (indent was used instead). This caused a crash when dumping out heartbeat events.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Other (please specify below)

Checklist

  • I have read and understood the CONTRIBUTING.md document.
  • I have checked there aren't any other open Pull Requests for the desired changes.
  • This PR resolves an issue #[Issue Number Here].

Tests

  • All tests have passed.
  • New tests have been added to cover the changes. (describe below if applicable).

Additional Information

I tested this change manually, but haven't added tests yet. Feel free to suggest a good spot for this test and I'll be happy to take another pass.

@julien-duponchelle
Copy link
Owner

Good catch !

@julien-duponchelle julien-duponchelle merged commit b933500 into julien-duponchelle:main Jul 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants