Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint error & remove black #621

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Fix lint error & remove black #621

merged 2 commits into from
Aug 11, 2024

Conversation

julien-duponchelle
Copy link
Owner

@julien-duponchelle julien-duponchelle commented Jul 27, 2024

Related to #620

Update the lint script and configuration files to fix the lint error. And remove black because ruff replace it.

  • scripts/lint.sh

    • Update the ruff command to use ruff check instead of ruff.
    • Remove the black command.
  • .github/workflows/lint.yml

    • Remove black from the Install dependencies step.
  • .pre-commit-config.yaml

    • Remove the black dependency.

For more details, open the Copilot Workspace session.

Related to #620

Update the lint script and configuration files to fix the lint error. And remove black because ruff replace it.

* **scripts/lint.sh**
  - Update the `ruff` command to use `ruff check` instead of `ruff`.
  - Remove the `black` command.

* **.github/workflows/lint.yml**
  - Remove `black` from the `Install dependencies` step.

* **.pre-commit-config.yaml**
  - Remove the `black` dependency.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/julien-duponchelle/python-mysql-replication/issues/620?shareId=XXXX-XXXX-XXXX-XXXX).
@julien-duponchelle
Copy link
Owner Author

julien-duponchelle commented Jul 28, 2024

I will fix the pipeline when coming back from holiday

@julien-duponchelle julien-duponchelle merged commit 3397d39 into main Aug 11, 2024
13 checks passed
@julien-duponchelle julien-duponchelle deleted the fix-lint-error branch August 11, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant