Use same contentScale when loading images with coil (#6)

When applying a non-default contentScale it must be applied to both the `rememberAsyncImagePainter` and the `Image`
julioromano · Mar 9, 2023 · df65528 · df65528
1 parent 4ec3b4e
commit df65528
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/movie/src/main/kotlin/net/marcoromano/tmdb/movie/widgets/Movie.kt b/movie/src/main/kotlin/net/marcoromano/tmdb/movie/widgets/Movie.kt
@@ -38,22 +38,24 @@ internal fun Movie(
     Box(
       contentAlignment = Alignment.Center,
     ) {
+      val contentScale = ContentScale.Crop
       Image(
         painter = rememberAsyncImagePainter(
           model = ImageRequest.Builder(LocalContext.current)
             .data("https://image.tmdb.org/t/p/w1280/${movie.backdrop_path}")
             .size(width = 1280, height = 720)
+            .placeholder(ColorDrawable(Color.YELLOW)) // TODO: Make it better looking.
+            .error(android.R.drawable.ic_dialog_alert) // TODO: Can be better looking.
             .crossfade(true)
             .build(),
+          contentScale = contentScale,
         ),
         contentDescription = null,
         modifier = Modifier
           .height(340.dp)
           .fillMaxWidth()
           .alpha(0.5f),
-        // Don't use placeholders with a non default contentScale or there can be
-        // glitches: https://github.com/coil-kt/coil/issues/855
-        contentScale = ContentScale.Crop,
+        contentScale = contentScale,
       )
       Image(
         painter = rememberAsyncImagePainter(