kserve: Update the Models web app (kubeflow#2158)

Update the app's manifests to: 1. Work under the /kserve-endpoints prefix 2. Use the correct gatway in the manifests 3. Use the correct namespace in for the app's ConfigMap Signed-off-by: Kimonas Sotirchos <[email protected]>
juliusvonkohout · Feb 28, 2023 · 5576416 · 5576416
1 parent 8c8d585
commit 5576416
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/contrib/kserve/models-web-app/base/istio.yaml b/contrib/kserve/models-web-app/base/istio.yaml
@@ -5,7 +5,7 @@ metadata:
   namespace: kserve
 spec:
   gateways:
-  - $(ingressGateway)
+  - knative-serving/knative-ingress-gateway
   hosts:
   - '*'
   http:

diff --git a/contrib/kserve/models-web-app/base/kustomization.yaml b/contrib/kserve/models-web-app/base/kustomization.yaml
@@ -12,5 +12,6 @@ images:
   newTag: v0.7.0
 configMapGenerator:
   - name: kserve-models-web-app-config
+    namespace: kserve
     literals:
     - APP_DISABLE_AUTH="True"
diff --git a/contrib/kserve/models-web-app/overlays/kubeflow/kustomization.yaml b/contrib/kserve/models-web-app/overlays/kubeflow/kustomization.yaml
@@ -33,9 +33,11 @@ generatorOptions:
 # kserve namespace in webhook configurations
 configMapGenerator:
   - name: kserve-models-web-app-config
+    namespace: kserve
     behavior: replace
     literals:
     - USERID_HEADER=kubeflow-userid
+    - APP_PREFIX=/kserve-endpoints
 
 configurations:
 - params.yaml
diff --git a/contrib/kserve/models-web-app/overlays/kubeflow/patches/web-app-vsvc.yaml b/contrib/kserve/models-web-app/overlays/kubeflow/patches/web-app-vsvc.yaml
@@ -1,3 +1,7 @@
+- op: replace
+  path: /spec/gateways
+  value:
+    - kubeflow/kubeflow-gateway
 - op: replace
   path: /spec/http/0/route/0/destination
   value: