Preparando review #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidneyouteiro
commented
Jul 12, 2021
| <form onSubmit={addRegister}> | ||
| <Input type="number" value={amount} setValue={setAmount} disabled={loading} placeholder="Valor" /> | ||
| <Input type="text" value={description} setValue={setDescription} disabled={loading} placeholder="Descrição" /> | ||
| <Button type="submit">{loading ? <ThreeDots /> : "Salvar entrada"}</Button> |
There was a problem hiding this comment.
Gostei bastante desse recurso visual. Bom trabalho! 👍🏽
Comment on lines
-1
to
-54
| import Input from "./Input"; | ||
| import Button from "./Button"; | ||
| import {Container, Back} from "./Styles"; | ||
| import { Link, useHistory } from "react-router-dom"; | ||
| import UserContext from './contexts/UserContext'; | ||
| import { useContext, useState } from "react"; | ||
| import axios from "axios"; | ||
| import ThreeDots from "./ThreeDots"; | ||
|
|
||
| export default function CashOut() { | ||
| const { user } = useContext(UserContext); | ||
| const [amount, setAmount] = useState(""); | ||
| const [description, setDescription] = useState(""); | ||
| const [loading, setLoading] = useState(false); | ||
| const history = useHistory() | ||
|
|
||
| function addNewRegister(e) { | ||
| e.preventDefault(); | ||
|
|
||
| const config = { headers: { Authorization: `Bearer ${user}` } }; | ||
|
|
||
| if (amount >= 0) return alert("Você deve adicionar saídas com valores negativos!") | ||
|
|
||
| const number = amount?.replace(",", ".") | ||
| const value = Number(number).toFixed(2) * 100; | ||
| const body = { value, description }; | ||
|
|
||
| const request = axios.post(`http://localhost:4000/cashout`, body, config); | ||
| setLoading(true); | ||
| request.then(() => { | ||
| setAmount(""); | ||
| setDescription(""); | ||
| history.push("/home") | ||
| setLoading(false); | ||
| }) | ||
| request.catch(() => { | ||
| alert("Algo deu errado!") | ||
| setLoading(false); | ||
| }) | ||
| } | ||
| return ( | ||
| <> | ||
| <Container> | ||
| <p>Nova Saída</p> | ||
| <form onSubmit={addNewRegister}> | ||
| <Input type="number" value={amount} setValue={setAmount} disabled={loading} placeholder="Valor" /> | ||
| <Input type="text" value={description} setValue={setDescription} disabled={loading} placeholder="Descrição" /> | ||
| <Button type="submit">{loading ? <ThreeDots /> : "Salvar saída"}</Button> | ||
| </form> | ||
| </Container> | ||
| <Link to="/home"><Back>Voltar</Back></Link> | ||
| </> | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Poderíamos ter um componente só para lidar com a entrada e saída e fazer o controle através de uma variável isso reduziria o código duplicado.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.