Fix bug copying expressions that do not contain variables

jump-dev · Feb 3, 2025 · 9145948 · 9145948
1 parent b734e12
commit 9145948
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/copy.jl b/src/copy.jl
@@ -45,6 +45,11 @@ end
 
 const ReferenceMap = GenericReferenceMap{Float64}
 
+# Some fallbacks for Base types that we should pass through un-changed
+Base.getindex(::GenericReferenceMap, x::Number) = x
+Base.getindex(::GenericReferenceMap, x::AbstractString) = x
+Base.getindex(::GenericReferenceMap, x::Symbol) = x
+
 function Base.getindex(map::GenericReferenceMap, vref::GenericVariableRef)
     return GenericVariableRef(map.model, map.index_map[index(vref)])
 end

diff --git a/test/test_model.jl b/test/test_model.jl
@@ -1465,4 +1465,18 @@ function test_solver_name_error()
     return
 end
 
+function test_copy_base_types()
+    model = Model()
+    @expression(model, a, 1.0)
+    @expression(model, b, "Bb")
+    @expression(model, c, :c)
+    @expression(model, d, BigInt(1) + BigInt(2) * im)
+    new_model = copy(model)
+    @test new_model[:a] === 1.0
+    @test new_model[:b] == "Bb"
+    @test new_model[:c] == :c
+    @test new_model[:d] == BigInt(1) + BigInt(2) * im
+    return
+end
+
 end  # module TestModels