HTTP -> HTTPS except POM headers and Maven Wrapper files (#120)

[LIttleAncientForestKami]

Overview

• Java files have Javadocs changed: URLs now use https
• grep http **/* -r | grep -v https was used for testing / looking for places to change
• all links I changed worked in their changed version
• the issue says (in bold even) all files, so do let me know if it really is what was meant @sormuras and @marcphilipp - I didn't fully follow, since:
• Maven wrapper files are IIRC autogenerated, so I did not make changes there
• Maven POM documentation and example use http for XML namespaces in the headers, and both http and https link fail their resolution. Example docs: https://maven.apache.org/pom.html - so XML headers I made as Maven docs have them, in case some legacy tooling needs that.

Let me know what else's needed.

I hereby agree to the terms of the JUnit Contributor License Agreement.

[sormuras]

Thanks for submitting this PR Tomasz - please address the request changes.

[sbrannen]

Thanks for the PR.

It would be better to introduce nohttp into the build(s) instead of manually grepping.

Perhaps you'd like to introduce nohttp with this PR.

[sbrannen]

Note that nohttp is already used in the builds for JUnit 5. See:

• https://github.com/junit-team/junit5/blob/main/build.gradle.kts
• https://github.com/junit-team/junit5/blob/main/settings.gradle.kts

[sormuras]

I guess, I found another candidate for adding a s to right URI:

junit5-samples/junit5-migration-maven/pom.xml

Line 3 in 891ae18

xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

Is there a standalone nohttp variant, not needing a build tool integreation?
Asking for "ant", "bazel", and "modular-world" samples.

[sbrannen]

I guess, I found another candidate for adding a s to right URI:

nohttp should inform us about everything this PR misses, and it will do that for every build.

Is there a standalone nohttp variant, not needing a build tool integreation?

Yes. Check out the project page. There's a CLI, Checkstyle support, and Gradle support.

https://github.com/spring-io/nohttp#modules

[LIttleAncientForestKami]

Hi fellas! Thanks for lots of good points, will go through them soon. I just became a father!! Writing this to not ghost you and let you know. Nohttp sounds like just what is needed and remarks about XML headers are on point. Once I'm done should I squash the commits?

[sbrannen]

I just became a father!!

Congratulations! 👶

Nohttp sounds like just what is needed and remarks about XML headers are on point.

👍

Once I'm done should I squash the commits?

Yes, that would be fine. Feel free to rename the issue, rework the description, squash commits, rebase on main, and force push the changes to your PR branch.

[donphelix]

LGTM

[LIttleAncientForestKami]

Thank you for the review and approve! Also, where's my thumb up Jesus? 😉 (Seeing lgtm without it feels incomplete now... https://memegenerator.net/instance/65177257/thumbs-up-jesus-1000-lines-of-code-changed-lgtm ) śr., 6 lis 2024, 09:25 użytkownik Don Phelix ***@***.***> napisał:

…

***@***.**** approved this pull request. LGTM — Reply to this email directly, view it on GitHub <#175 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAI5DQ5B3GHUH4E5FVCAXMDZ7HHA7AVCNFSM6AAAAABRIIQV6OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJXGUZTOMRUG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[marcphilipp]

@LIttleAncientForestKami Thanks for your initial work! I just pushed it over the finish line. There's now a GitHub Action that runs nohttp.