feat(meter): create new component #695
Merged
+576
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielduete
changed the title
|
gabrielduete
changed the title
gabrielduete
requested review from
a team,
dyhalmeida,
mauriciomutte,
luiz-ortega and
jowjow22
and removed request for
a team
tassioFront
reviewed
Feb 5, 2025
tassioFront
reviewed
Feb 5, 2025
tassioFront
reviewed
Feb 5, 2025
tassioFront
reviewed
Feb 5, 2025
…ais/atomium into feat/create-component-meter
felipefialho
requested changes
Feb 5, 2025
gabrielduete
requested review from
tassioFront,
felipefialho,
anabrook and
brunosf
tassioFront
previously approved these changes
Feb 6, 2025
luiz-ortega
previously approved these changes
Feb 6, 2025
felipefialho
requested changes
Feb 6, 2025
gabrielduete
dismissed stale reviews from luiz-ortega and tassioFront
via
7a1570d
felipefialho
previously approved these changes
Feb 6, 2025
tassioFront
previously approved these changes
Feb 6, 2025
gabrielduete
dismissed stale reviews from tassioFront and felipefialho
via
04727a6
|
tassioFront
approved these changes
Feb 6, 2025
luiz-ortega
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infos
Task
What is being delivered?
New Component Addition:
packages/core/src/components/meter/meter.tsx: Introduced theAtomMetercomponent with properties such astype,size,title,centerTitle,min,max, andactual. The component includes methods for calculating progress and rendering based on props.Styling:
packages/core/src/components/meter/meter.scss: Added styles for theAtomMetercomponent, including layout, typography, and different states like success, warning, and danger.Testing:
packages/core/src/components/meter/meter.spec.ts: Added unit tests for theAtomMetercomponent to ensure it renders correctly with different props and children.Storybook Configurations:
packages/core/src/components/meter/stories/meter.args.tsx: Defined story arguments for theAtomMetercomponent, including controls and descriptions for each prop.packages/core/src/components/meter/stories/meter.core.stories.tsx: Added storybook stories for theAtomMetercomponent using the web-components framework.packages/core/src/components/meter/stories/meter.react.stories.tsx: Added storybook stories for theAtomMetercomponent using the React framework.packages/core/src/components/meter/stories/meter.vue.stories.tsx: Added storybook stories for theAtomMetercomponent using the Vue framework.Minor Adjustments:
packages/core/src/components/badge/stories/badge.vue.stories.tsx: Reordered imports for consistency.Closes: #103
What impacts?
Core components | React Components | Vue Components
Reversal plan
Revert PR #695
Evidences
Gravacao.de.Tela.2025-02-05.as.10.12.42.mov