fix: fix override model save method #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugobrilhante
commented
Jan 20, 2024
| @@ -125,7 +126,6 @@ def my_serializer_1(obj): | |||
| self.assertEqual("", published[1].body["last_name"]) | |||
| self.assertEqual("", published[1].body["first_name"]) | |||
| self.assertIsNone(published[1].body["last_login"]) | |||
| self.assertAlmostEqual(date_joined.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3], published[1].body["date_joined"]) | |||
There was a problem hiding this comment.
This line was removed because it caused inconsistency in the tests, sometimes passing, sometimes not.
There was a problem hiding this comment.
what do you think about use a freezegun ever than remove the line ?
hugobrilhante
force-pushed
the
fix/override-save-method
branch
from
09a77ad to
afdf5ee
Compare
hugobrilhante
force-pushed
the
fix/override-save-method
branch
from
afdf5ee to
2272894
Compare
| @@ -1,3 +1,4 @@ | |||
| # pylint: disable=protected-access | |||
There was a problem hiding this comment.
question: What is the motivation to include this bypass? Not is possible to remove that?
| @@ -125,7 +126,6 @@ def my_serializer_1(obj): | |||
| self.assertEqual("", published[1].body["last_name"]) | |||
| self.assertEqual("", published[1].body["first_name"]) | |||
| self.assertIsNone(published[1].body["last_login"]) | |||
| self.assertAlmostEqual(date_joined.strftime("%Y-%m-%dT%H:%M:%S.%f")[:-3], published[1].body["date_joined"]) | |||
There was a problem hiding this comment.
what do you think about use a freezegun ever than remove the line ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a, perhaps critical, issue, which was the overlap of the
savemethod in the model. Without the correction, it is not possible to perform actions as shown in the example because thesavemethod will never be executed.