New Top Token List #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrowana
approved these changes
Nov 29, 2024
melvinzhang
requested changes
Nov 29, 2024
Yeap, will do. I won't be matching this PR for now because I can fetch this list off this branch and it's good enough for now. |
|
Did not plan to close this but it auto closed when I merged #17 We need to keep this branch around as it is still being used. |
|
@boxme Have we deployed the Quote API that no longer depends on this branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have an existing list
dynamic_slippage_config.jsonfor dynamic slippage config setup based on token categories. We want to combine it with top token list.To avoid disrupting anything related to prod, we don't want to modify the existing
dynamic_slippage_config.json.Solution
A new updated list
top_tokens_config.json. The changes also addition and removal of tokens from @0xSoju2 suggestions https://github.com/jup-ag/jupiter-core-rs/pull/1594/files