Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @agoose77 👋 .
I noticed the current main branch is failing due to a linting error, which is my first commit of the two here. Then there is an error stemming from this line in the workflow.yml GH actions file:
python -c 'from packaging.version import Version; from importlib.metadata import version as version_of; raise SystemExit(Version(version_of('\''jupyterlab'\'')) > Version('\''4.0.6'\''))'
This I'm less sure how the EB team wants to handle but I modified the max version
> Version('\''4.0.6'\''))
to> Version('\''4.0.7'\''))
since that's the latest jupyterlab version and this constraint inpyproject.toml
will install the latest 4.x.x version."python -m pip install 'jupyterlab>=4.0.0,<5'"
Anyway fixes the CI on my fork. Let me know if any issues with these changes.
Jameson