-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Add outputs
to spec
#66
Draft
agoose77
wants to merge
8
commits into
main
Choose a base branch
from
agoose77/feat-outputs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+154
−46
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f9e5fab
docs: add docs for outputs
agoose77 189a684
chore: add to toc
agoose77 7e23360
feat: add new schema
agoose77 f2650d2
chore: drop JB configs
agoose77 fdbfefa
fix: typo
agoose77 3a638c8
test: skip tests without myst
agoose77 2fd8952
fix: include outputs
agoose77 e2aadbd
fix: typo
agoose77 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
cases: | ||
- title: output with children | ||
mdast: | ||
type: root | ||
children: | ||
- type: output | ||
meta: | ||
'text/plain': Hello world! | ||
children: | ||
- type: paragraph | ||
children: | ||
- type: text | ||
value: Hello world! | ||
- title: output without children | ||
mdast: | ||
type: root | ||
children: | ||
- type: output | ||
meta: | ||
'application/json': '{"foo": 12}' | ||
children: [] | ||
- title: outputs with children | ||
mdast: | ||
type: root | ||
children: | ||
- type: outputs | ||
children: | ||
- type: output | ||
meta: | ||
'text/plain': Hello world! | ||
children: | ||
- type: paragraph | ||
children: | ||
- type: text | ||
value: Hello world! | ||
- title: outputs without children | ||
mdast: | ||
type: root | ||
children: | ||
- type: outputs | ||
children: | ||
- type: output | ||
meta: | ||
'application/json': '{"foo": 12}' | ||
children: [] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
|
||
# Execution Outputs | ||
|
||
## Outputs | ||
|
||
`Outputs` provide a structural container for the outputs produced by a Jupyter kernel. | ||
|
||
|
||
### Specification | ||
|
||
```{include} ../nodes/outputs.md | ||
``` | ||
|
||
### Example | ||
|
||
```{include} ../examples/outputs.md | ||
``` | ||
|
||
## Output | ||
|
||
Individual outputs from a Jupyer kernel may be embedded in an `output` node. | ||
|
||
|
||
### Specification | ||
|
||
```{include} ../nodes/output.md | ||
``` | ||
|
||
### Example | ||
|
||
```{include} ../examples/output.md | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
{ | ||
"$schema": "http://json-schema.org/draft-07/schema#", | ||
"$id": "https://spec.myst.tools/json-schema/outputs.schema.json", | ||
"description": "execution output container types", | ||
"$defs": { | ||
"Output": { | ||
"type": "object", | ||
"description": "Container for execution output from a Jupyer Kernel", | ||
"allOf": [ | ||
{ | ||
"properties": { | ||
"type": { | ||
"const": "output" | ||
}, | ||
"meta": { | ||
"description": "Raw IOutput data", | ||
"$ref": "https://raw.githubusercontent.com/jupyter/nbformat/refs/heads/main/nbformat/v4/nbformat.v4.5.schema.json#/definitions/output" | ||
}, | ||
"children": { | ||
"description": "Children from parsing the raw IOutput data", | ||
"type": "array", | ||
"items": { | ||
"$ref": "unist.schema.json#/$defs/Node" | ||
} | ||
}, | ||
"position": {}, | ||
"data": {} | ||
}, | ||
"additionalProperties": false | ||
}, | ||
{ "$ref": "unist.schema.json#/$defs/Parent" } | ||
] | ||
}, | ||
"Outputs": { | ||
"type": "object", | ||
"description": "Container for a collection of execution outputs from a Jupyer Kernel", | ||
"allOf": [ | ||
{ | ||
"properties": { | ||
"type": { | ||
"const": "outputs" | ||
}, | ||
"children": { | ||
"description": "Individual output nodes", | ||
"type": "array", | ||
"items": { | ||
"$ref": "#/$defs/Output" | ||
} | ||
}, | ||
"position": {}, | ||
"data": {} | ||
}, | ||
"additionalProperties": false | ||
}, | ||
{ "$ref": "unist.schema.json#/$defs/Parent" } | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing to test here -- outputs are programmatically generated.