🎨 Update citation styles (#236)

This allows citations in a group to be more than a `cite` html element.
jupyter-book · Sep 26, 2023 · bf66da0 · bf66da0
1 parent 55f7d0f
commit bf66da0
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.changeset/silver-bananas-kiss.md b/.changeset/silver-bananas-kiss.md
@@ -0,0 +1,6 @@
+---
+'myst-to-react': patch
+'@myst-theme/styles': patch
+---
+
+Allow citations to be elements other than `cite` (e.g. a Figure 1 reference is a span element.)
diff --git a/packages/myst-to-react/src/cite.tsx b/packages/myst-to-react/src/cite.tsx
@@ -48,7 +48,7 @@ export const Cite = ({
   const doiUrl = doiString ? doi.buildUrl(doiString as string) : null;
   return (
     <HoverPopover openDelay={300} card={<CiteChild html={html} />}>
-      <cite className="hover-link">
+      <cite>
         {doiUrl && (
           <a href={doiUrl} target="_blank" rel="noreferrer" className="hover-link">
             {children}

diff --git a/styles/citations.css b/styles/citations.css
@@ -1,13 +1,13 @@
 cite {
   font-style: normal;
 }
-.cite-group.parenthetical cite::after {
+.cite-group.parenthetical > *::after {
   content: ';\00a0';
 }
-.cite-group.narrative cite::after {
+.cite-group.narrative > *::after {
   content: ',\00a0';
 }
-.cite-group > cite:last-of-type::after {
+.cite-group > *:last-of-type::after {
   content: '';
 }
 .cite-group.parenthetical:before {