🧮 Look to remoteBaseUrl instead of location for disabling jupyter com…

…putation (#382)
jupyter-book · May 10, 2024 · d2897c9 · d2897c9
1 parent d1d2b7f
commit d2897c9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/.changeset/giant-bugs-rest.md b/.changeset/giant-bugs-rest.md
@@ -2,4 +2,4 @@
 '@myst-theme/jupyter': patch
 ---
 
-Require location on node source to enable jupyter computation
+Disable jupyter computation on nodes if remoteBaseUrl is present
diff --git a/packages/jupyter/src/decoration.tsx b/packages/jupyter/src/decoration.tsx
@@ -32,14 +32,14 @@ export function OutputDecoration({
   children,
   title = 'Jupyter Notebook',
   url,
-  location,
+  remoteBaseUrl,
 }: {
   outputId: string;
   placeholder?: GenericNode;
   children?: React.ReactNode;
   title?: string;
   url?: string;
-  location?: string;
+  remoteBaseUrl?: string;
 }) {
   const { kind } = useCellExecution(outputId);
   const compute = useComputeOptions();
@@ -50,7 +50,7 @@ export function OutputDecoration({
     compute?.enabled &&
     compute?.features.figureCompute &&
     kind === SourceFileKind.Article &&
-    location;
+    !remoteBaseUrl;
 
   if (showComputeControls) {
     return (
@@ -65,7 +65,7 @@ export function OutputDecoration({
               <span className="ml-2">Source:</span>
               {url && (
                 <Link
-                  to={withBaseurl(url, baseurl)}
+                  to={withBaseurl(url, remoteBaseUrl ?? baseurl)}
                   className="ml-2 no-underline text-normal hover:underline"
                 >
                   {title}
@@ -92,7 +92,7 @@ export function OutputDecoration({
           <div className="ml-1">Source:</div>
           {url && (
             <Link
-              to={withBaseurl(url, baseurl)}
+              to={withBaseurl(url, remoteBaseUrl ?? baseurl)}
               className="ml-1 no-underline text-normal hover:underline"
             >
               {title}

diff --git a/packages/jupyter/src/embed.tsx b/packages/jupyter/src/embed.tsx
@@ -11,7 +11,7 @@ export function Embed({ node }: { node: GenericNode }) {
       outputId={output.id}
       title={node.source?.title}
       url={node.source?.url}
-      location={node.source?.location}
+      remoteBaseUrl={node.source?.remoteBaseUrl}
     >
       <MyST ast={node.children} />
     </OutputDecoration>

diff --git a/packages/jupyter/src/figure.tsx b/packages/jupyter/src/figure.tsx
@@ -22,7 +22,7 @@ export function Figure({ node }: { node: GenericNode }) {
           placeholder={placeholder}
           title={node.source?.title}
           url={node.source?.url}
-          location={node.source?.location}
+          remoteBaseUrl={node.source?.remoteBaseUrl}
         >
           <MyST ast={others} />
         </OutputDecoration>