Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ More preparation for Remix v2 (1) #408

Merged
merged 7 commits into from
Aug 26, 2024

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jun 20, 2024

More work on preparing for v2 in Remix, fixing CatchBoundary and some other small changes.

@agoose77 agoose77 self-assigned this Jun 20, 2024
@agoose77 agoose77 force-pushed the agoose77/refactor-prepare-for-v2 branch from a3ed2f1 to 802d865 Compare June 20, 2024 12:44
@agoose77 agoose77 marked this pull request as ready for review June 20, 2024 12:44
@agoose77 agoose77 requested a review from stevejpurves June 20, 2024 12:44
@agoose77 agoose77 force-pushed the agoose77/refactor-prepare-for-v2 branch from 802d865 to f34fc9f Compare June 20, 2024 12:51
@agoose77 agoose77 force-pushed the agoose77/refactor-prepare-for-v2 branch from 6ca7c46 to 984190e Compare June 20, 2024 14:48
@agoose77
Copy link
Collaborator Author

I noticed during upgrade work that despite v2_routeConvention being set, I had to backport to v1 routing to fix some navigation bugs. I won't tackle that here, as I don't firmly understand the problem yet.

@agoose77 agoose77 changed the title ⚙️ More preparation for Remix v2 ⚙️ More preparation for Remix v2 (1) Jun 21, 2024
@agoose77
Copy link
Collaborator Author

agoose77 commented Jul 5, 2024

@stevejpurves can we merge this? It silences warnings and doesn't break anything to my knowledge.

@rowanc1 rowanc1 assigned stevejpurves and unassigned agoose77 Aug 20, 2024
Copy link

changeset-bot bot commented Aug 20, 2024

🦋 Changeset detected

Latest commit: 96b4345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@myst-theme/site Minor
@myst-theme/article Minor
@myst-theme/book Minor
@myst-theme/providers Minor
@myst-theme/frontmatter Minor
@myst-theme/diagrams Minor
@myst-theme/jupyter Minor
@myst-theme/styles Minor
@myst-theme/common Minor
@myst-theme/icons Minor
myst-to-react Minor
myst-demo Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@stevejpurves stevejpurves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested out locally - looks good!

@stevejpurves stevejpurves merged commit 6ca6dbb into main Aug 26, 2024
2 checks passed
@stevejpurves stevejpurves deleted the agoose77/refactor-prepare-for-v2 branch August 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants