Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0️⃣ Support null dates #451

Closed
wants to merge 2 commits into from
Closed

Conversation

agoose77
Copy link
Collaborator

Fixes rendering of "now" dates (null)

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: b9caefe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@myst-theme/frontmatter Patch
@myst-theme/providers Patch
@myst-theme/diagrams Patch
@myst-theme/jupyter Patch
@myst-theme/site Patch
@myst-theme/styles Patch
@myst-theme/common Patch
@myst-theme/icons Patch
@myst-theme/book Patch
@myst-theme/article Patch
myst-to-react Patch
myst-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rowanc1
Copy link
Member

rowanc1 commented Aug 21, 2024

What is the use case for this? Can we send through "today" instead? null-ish to me means no date.

I can (maybe) see that a preprint/blog gets a today string, that is recognized by the CLI (not the theme) and then serialized to the frontend as the date it was built on. That is pretty dangerous though - it means all your blog posts are always written "today" whenever you rerender them (which is probably not what people want).

I don't know if I understand the use case where we want the frontend to show today's date whenever you refresh .. ?

@agoose77
Copy link
Collaborator Author

We discuss this over at mystmd, but the high level is that implicit 'today' is a bad thing. I'm closing this pr.

@agoose77 agoose77 closed this Aug 21, 2024
@rowanc1 rowanc1 deleted the agoose77/feat-fix-has-date branch August 22, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants