-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔍 💥 Add UX for client-side search #470
Conversation
🦋 Changeset detectedLatest commit: 4fd5216 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@stevejpurves @rowanc1 input always welcome, but I'll keep chipping away at this. |
Phew, made some good progress! My goal here is to build out "an approach", and then we can iterate on the design. |
343703e
to
35243a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In progress comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a user's perspective, based on the two videos above, I think that this is ready to ship and consider it an alpha-level feature. I like the UI responsiveness, and the results modal is a great start - +1 to mimicking the UI of Algolia since they've done a lot of UI research already.
I couldn't test this locally (tried to get this theme building for 15 minutes but couldn't figure it out) but my feeling is that we should try to get this into the hands of users for feedback sooner than later, it already feels ready to me from a functionality perspective.
Is there any major technical blocker that we need to work out first? If not, my vote is to ship this and iterate when we get feedback. I'm happy to start trying it out a bit more.
cac0a98
to
4cf43ac
Compare
…lient-side-search' into agoose77/feat-add-client-side-search
…lient-side-search' into agoose77/feat-add-client-side-search
This PR is a rough stab at a frontend component for client-side search. There are already some sharp edges to rework:
@myst-theme/search
in@myst-theme/common
oncemystmd
exportsmyst-spec-ext
with the latest tyeps2024-09-23.19-51-13.mp4
Note
To test this PR:
myst start --headless
theme:book
as usual