👩💻 Fix SSR styling of code-blocks #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e561a28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rowanc1
reviewed
Sep 30, 2024
rowanc1
reviewed
Sep 30, 2024
|
@rowanc1 I've just lifted the CSS from highlightjs directly into our styling. This means that we don't need to duplicate any nodes. Are you comfortable with this change? |
agoose77
commented
Oct 15, 2024
Comment on lines
-3
to
-4
| import light from 'react-syntax-highlighter/dist/esm/styles/hljs/xcode.js'; | ||
| import dark from 'react-syntax-highlighter/dist/esm/styles/hljs/vs2015.js'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent theme work moved theme logic entirely client-side1, so that we can support client-only theme configuration (
localStorage).This PR vendors the current styles that we use from
highlight.js, and adds selectors for the dark-mode variant. This means that we can set the theme entirely client-side.Closes #473
Footnotes
Technically SSR can render the proper state server-side, but for first-visits, we have to wait for the client to compute the proper state (and do some hydration-hacks to resolve the state). ↩