Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌠 Support TIFF images #285

Merged
merged 1 commit into from
Mar 1, 2023
Merged

🌠 Support TIFF images #285

merged 1 commit into from
Mar 1, 2023

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Mar 1, 2023

See #283.

fwkoch
fwkoch approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave this a spin and it seems to work fine. Looking at this PR and the entire transform itself, this code is in desperate need of a refactor, but that can be tackled separately. Issue for that is here: #287

@rowanc1 rowanc1 merged commit b1b1eb6 into main Mar 1, 2023
@rowanc1 rowanc1 deleted the feat/images branch March 1, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwkoch fwkoch fwkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanc1 @fwkoch