[wip] Add completion configurer

.gitignore

@@ -113,6 +113,6 @@ atest/output/
 junit.xml
 coverage/
 .vscode/
-_schema.d.ts
+_*.d.ts
 _build
 .virtual_documents/

atest/00_Smoke.robot

@@ -1,6 +1,6 @@
 *** Settings ***
 Suite Setup       Set Screenshot Directory    ${OUTPUT DIR}${/}screenshots${/}smoke
-Resource          Keywords.robot
+Resource          keywords/Common.robot
 
 *** Test Cases ***
 Lab Version

atest/01_Editor.robot

@@ -1,7 +1,7 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    editor
 Force Tags        ui:editor
-Resource          Keywords.robot
+Resource          keywords/Common.robot
 Resource          Variables.robot
 
 *** Test Cases ***
@@ -77,7 +77,7 @@ Editor Shows Features for Language
         ...    ELSE IF    "${f}" == "Rename"    Editor Should Rename    ${features["${f}"]}
     END
     Capture Page Screenshot    99-done.png
-    [Teardown]    Clean Up After Working With File    ${file}
+    [Teardown]    Clean Up After Working With Files    ${file}
 
 Editor Should Show Diagnostics
     [Arguments]    ${diagnostic}

atest/02_Settings.robot

@@ -1,6 +1,6 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    settings
-Resource          Keywords.robot
+Resource          keywords/Common.robot
 
 *** Test Cases ***
 Settings

atest/03_Notebook.robot

@@ -1,15 +1,15 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    notebook
 Test Setup        Try to Close All Tabs
-Resource          Keywords.robot
+Resource          keywords/Common.robot
 
 *** Test Cases ***
 Python
     [Setup]    Setup Notebook    Python    Python.ipynb
     ${diagnostic} =    Set Variable    W291 trailing whitespace (pycodestyle)
     Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title="${diagnostic}"]    timeout=35s
     Capture Page Screenshot    01-python.png
-    [Teardown]    Clean Up After Working With File    Python.ipynb
+    [Teardown]    Clean Up After Working With Files    Python.ipynb
 
 Foreign Extractors
     ${file} =    Set Variable    Foreign extractors.ipynb

atest/04_Interface/DiagnosticsPanel.robot

@@ -1,14 +1,14 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    diagnostics_panel
-Resource          ../Keywords.robot
-Test Setup        Set Up
-Test Teardown     Clean Up
+Resource          ../keywords/Common.robot
+Test Setup        Set Up Diagnostic Panel Test
+Test Teardown     Clean Up Diagnostic Panel Test
 
 *** Variables ***
 ${EXPECTED_COUNT}    1
 ${DIAGNOSTIC}     W291 trailing whitespace (pycodestyle)
 ${DIAGNOSTIC MESSAGE}    trailing whitespace
-${MENU COLUMNS}    xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), "columns")]
+${MENU COLUMNS}    ${JLAB XP MENU ITEM LABEL}\[contains(text(), "columns")]
 ${LAB MENU}       css:.lm-Menu
 
 *** Test Cases ***
@@ -25,7 +25,7 @@ Diagnostics Panel Works After Rename
     Open Diagnostics Panel
     Capture Page Screenshot    01-panel-rename.png
     Wait Until Keyword Succeeds    10 x    1s    Should Have Expected Rows Count    ${EXPECTED_COUNT}
-    Clean Up After Working With File    PanelRenamed.ipynb
+    Clean Up After Working With Files    PanelRenamed.ipynb
 
 Diagnostics Panel Can Be Restored
     Close Diagnostics Panel
@@ -70,7 +70,7 @@ Diagnostic Message Can Be Copied
 *** Keywords ***
 Expand Menu Entry
     [Arguments]    ${label}
-    ${entry} =    Set Variable    xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), "${label}")]
+    ${entry} =    Set Variable    ${JLAB XP MENU ITEM LABEL}\[contains(text(), "${label}")]
     Wait Until Page Contains Element    ${entry}    timeout=10s
     ${menus before} =    Get Element Count    ${LAB MENU}
     Mouse Over    ${entry}
@@ -84,7 +84,7 @@ Menus Count Equal
 
 Select Menu Entry
     [Arguments]    ${label}
-    ${entry}    Set Variable    xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), '${label}')]
+    ${entry}    Set Variable    ${JLAB XP MENU ITEM LABEL}\[contains(text(), '${label}')]
     Wait Until Page Contains Element    ${entry}    timeout=10s
     Mouse Over    ${entry}
     Click Element    ${entry}
@@ -93,7 +93,7 @@ Select Menu Entry
 Open Notebook And Panel
     [Arguments]    ${notebook}
     Setup Notebook    Python    ${notebook}
-    Capture Page Screenshot    00-notebook-and-panel-openeing.png
+    Capture Page Screenshot    00-notebook-and-panel-opening.png
     Wait Until Page Contains Element    css:.cm-lsp-diagnostic[title*="${DIAGNOSTIC}"]    timeout=20s
     Open Diagnostics Panel
     Capture Page Screenshot    00-notebook-and-panel-opened.png
@@ -103,11 +103,11 @@ Should Have Expected Rows Count
     ${count} =    Count Diagnostics In Panel
     Should Be True    ${count} == ${expected_count}
 
-Set Up
+Set Up Diagnostic Panel Test
     Gently Reset Workspace
     Open Notebook And Panel    Panel.ipynb
 
-Clean Up
-    Clean Up After Working With File    Panel.ipynb
-    Reset Plugin Settings    plugin=diagnostics
+Clean Up Diagnostic Panel Test
+    Clean Up After Working With Files    Panel.ipynb
+    Reset Plugin Settings
     Reset Application State

atest/04_Interface/Statusbar.robot

@@ -1,6 +1,6 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    statusbar
-Resource          ../Keywords.robot
+Resource          ../keywords/Common.robot
 
 *** Variables ***
 ${STATUSBAR}      css:div.lsp-statusbar-item
@@ -17,7 +17,7 @@ Statusbar Popup Opens
     Capture Page Screenshot    01-statusbar.png
     Element Should Contain    ${POPOVER}    python
     Element Should Contain    ${POPOVER}    initialized
-    [Teardown]    Clean Up After Working With File    Python.ipynb
+    [Teardown]    Clean Up After Working With Files    Python.ipynb
 
 Status Changes Correctly Between Editors
     Prepare File for Editing    Python    status    example.py
@@ -29,7 +29,7 @@ Status Changes Correctly Between Editors
     Wait Until Fully Initialized
     Switch To Tab    example.plain
     Wait Until Element Contains    ${STATUSBAR}    Initialized (additional servers needed)    timeout=60s
-    [Teardown]    Clean Up After Working With File    example.plain
+    [Teardown]    Clean Up After Working With Files    example.plain
 
 *** Keywords ***
 Switch To Tab

atest/05_Features/Completion.robot

@@ -1,12 +1,9 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    completion
 Test Setup        Setup Completion Test
-Test Teardown     Clean Up After Working With File    Completion.ipynb
+Test Teardown     Clean Up Completion Test
 Force Tags        feature:completion
-Resource          ../Keywords.robot
-
-*** Variables ***
-${COMPLETER_BOX}    css:.jp-Completer.jp-HoverBox
+Resource          ../keywords/Completion.robot
 
 *** Test Cases ***
 Works With Kernel Running
@@ -45,7 +42,6 @@ Works In File Editor
     Capture Page Screenshot    01-editor-ready.png
     Trigger Completer
     Completer Should Suggest    add
-    [Teardown]    Clean Up After Working With File    completion.py
 
 Autocompletes If Only One Option
     Enter Cell Editor    3    line=1
@@ -118,98 +114,5 @@ Triggers Completer On Dot
     Enter Cell Editor    2    line=1
     Press Keys    None    .
     Wait Until Keyword Succeeds    10x    0.5s    Cell Editor Should Equal    2    list.
-    Wait Until Page Contains Element    ${COMPLETER_BOX}    timeout=35s
+    Wait Until Page Contains Element    ${CSS COMPLETER BOX}    timeout=35s
     Completer Should Suggest    append
-
-Material Theme Works
-    Configure JupyterLab Plugin    {"theme": "material"}    plugin id=${COMPLETION PLUGIN ID}
-    Capture Page Screenshot    01-configured.png
-    Enter Cell Editor    1    line=2
-    Trigger Completer
-    Capture Page Screenshot    02-completions-shown.png
-    # TabError is a builtin exception which is a class in Python,
-    # so we should get lsp:material-class-light icon:
-    Completer Should Suggest    TabError
-    Completer Should Include Icon    lsp:material-class-light
-
-VSCode Theme Works
-    Configure JupyterLab Plugin    {"theme": "vscode"}    plugin id=${COMPLETION PLUGIN ID}
-    Capture Page Screenshot    01-configured.png
-    Enter Cell Editor    1    line=2
-    Trigger Completer
-    Capture Page Screenshot    02-completions-shown.png
-    Completer Should Suggest    TabError
-    Completer Should Include Icon    lsp:vscode-class-light
-
-VSCode Dark Theme Works
-    ${file} =    Set Variable    Completion.ipynb
-    Lab Command    Use JupyterLab Dark Theme
-    Wait For Splash
-    Capture Page Screenshot    00-theme-changed.png
-    Configure JupyterLab Plugin    {"theme": "vscode"}    plugin id=${COMPLETION PLUGIN ID}
-    Capture Page Screenshot    01-configured.png
-    Open ${file} in ${MENU NOTEBOOK}
-    Enter Cell Editor    1    line=2
-    Wait Until Fully Initialized
-    Trigger Completer
-    Capture Page Screenshot    02-completions-shown.png
-    Completer Should Suggest    TabError
-    Completer Should Include Icon    lsp:vscode-class-dark
-    Lab Command    Use JupyterLab Light Theme
-    Wait For Splash
-
-Works Without A Theme
-    Configure JupyterLab Plugin    {"theme": null}    plugin id=${COMPLETION PLUGIN ID}
-    Capture Page Screenshot    01-configured.png
-    Enter Cell Editor    1    line=2
-    Trigger Completer
-    Capture Page Screenshot    02-completions-shown.png
-    Completer Should Suggest    TabError
-    Wait Until Page Contains Element    ${COMPLETER_BOX} .jp-Completer-monogram
-
-Works With Incorrect Theme
-    Configure JupyterLab Plugin    {"theme": "a-non-existing-theme"}    plugin id=${COMPLETION PLUGIN ID}
-    Capture Page Screenshot    01-configured.png
-    Enter Cell Editor    1    line=2
-    Trigger Completer
-    Capture Page Screenshot    02-completions-shown.png
-    Completer Should Suggest    TabError
-    Wait Until Page Contains Element    ${COMPLETER_BOX} .jp-Completer-monogram
-
-*** Keywords ***
-Setup Completion Test
-    Setup Notebook    Python    Completion.ipynb
-
-Get Cell Editor Content
-    [Arguments]    ${cell_nr}
-    ${content}    Execute JavaScript    return document.querySelector('.jp-Cell:nth-child(${cell_nr}) .CodeMirror').CodeMirror.getValue()
-    [Return]    ${content}
-
-Cell Editor Should Equal
-    [Arguments]    ${cell}    ${value}
-    ${content} =    Get Cell Editor Content    ${cell}
-    Should Be Equal    ${content}    ${value}
-
-Select Completer Suggestion
-    [Arguments]    ${text}
-    ${suggestion} =    Set Variable    css:.jp-Completer-item[data-value="${text}"]
-    Wait Until Element Is Visible    ${suggestion}    timeout=10s
-    Mouse Over    ${suggestion}
-    Click Element    ${suggestion} code
-
-Completer Should Suggest
-    [Arguments]    ${text}
-    Wait Until Page Contains Element    ${COMPLETER_BOX} .jp-Completer-item[data-value="${text}"]    timeout=10s
-    Capture Page Screenshot    ${text.replace(' ', '_')}.png
-
-Completer Should Include Icon
-    [Arguments]    ${icon}
-    Wait Until Page Contains Element    ${COMPLETER_BOX} svg[data-icon="${icon}"]
-
-Completer Should Not Suggest
-    [Arguments]    ${text}
-    Wait Until Page Does Not Contain Element    ${COMPLETER_BOX} .jp-Completer-item[data-value="${text}"]
-
-Trigger Completer
-    Press Keys    None    TAB
-    Wait Until Page Contains Element    ${COMPLETER_BOX}    timeout=35s

atest/05_Features/Signature.robot

@@ -1,7 +1,7 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    signature
 Force Tags        feature:signature
-Resource          ../Keywords.robot
+Resource          ../keywords/Common.robot
 
 *** Variables ***
 ${SIGNATURE_BOX}    css:.lsp-signature-help
@@ -15,4 +15,4 @@ Triggers Signature Help After A Keystroke
     Capture Page Screenshot    02-signature-shown.png
     Wait Until Keyword Succeeds    20x    0.5s    Page Should Contain Element    ${SIGNATURE_BOX}
     Element Should Contain    ${SIGNATURE_BOX}    Important docstring of abc()
-    [Teardown]    Clean Up After Working With File    Signature.ipynb
+    [Teardown]    Clean Up After Working With Files    Signature.ipynb

atest/05_Features/Syntax_highlighting.robot

@@ -1,9 +1,9 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    syntax_highlighting
 Test Setup        Setup Highlighting Test
-Test Teardown     Clean Up After Working With File    Syntax highlighting.ipynb
+Test Teardown     Clean Up After Working With Files    Syntax highlighting.ipynb
 Force Tags        feature:syntax_highlighting
-Resource          ../Keywords.robot
+Resource          ../keywords/Common.robot
 
 *** Test Cases ***
 Syntax Highlighting Mode Stays Normal In Normal Cells

atest/06_Style.robot

@@ -1,7 +1,7 @@
 *** Settings ***
 Suite Setup       Setup Suite For Screenshots    style
 Force Tags        ui:editor    aspect:style
-Resource          Keywords.robot
+Resource          keywords/Common.robot
 Resource          Variables.robot
 Library           Collections
 
@@ -35,7 +35,7 @@ Screenshot Editor Themes with Lab Theme
     FOR    ${editor theme}    IN    @{THEME NAMES}
         Capture Theme Screenshot    ${editor theme}
     END
-    [Teardown]    Clean Up After Working With File    ${file}
+    [Teardown]    Clean Up After Working With Files    ${file}
 
 Capture Theme Screenshot
     [Arguments]    ${editor theme}
@@ -51,7 +51,7 @@ Click the second Accumulate in ${editor}
 Change Editor Theme
     [Arguments]    ${editor theme}
     Open Editor Theme Menu
-    ${sel} =    Set Variable    xpath://div[contains(@class, 'lm-Menu-itemLabel')][contains(text(), "${editor theme}")]
+    ${sel} =    Set Variable    ${JLAB XP MENU ITEM LABEL}\[contains(text(), "${editor theme}")]
     Wait Until Page Contains Element    ${sel}
     Mouse Over    ${sel}
     Click Element    ${sel}