Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langchain vector search PDF #2012

Conversation

srini047
Copy link
Member

Fixes: #1893

@srini047 srini047 added enhancement New feature or request templates maintainer To be prioritize for notebook templates maintainer labels Jul 12, 2023
@srini047 srini047 requested review from jravenel and FlorentLvr July 12, 2023 16:35
@srini047 srini047 self-assigned this Jul 12, 2023
@srini047 srini047 linked an issue Jul 12, 2023 that may be closed by this pull request
@FlorentLvr
Copy link
Contributor

FlorentLvr commented Jul 19, 2023

@srini047, just checked your notebook and i got an error while reading the PDF. Could you please create an example that could work anytime using a PDF from an external link ? 🙏

Thank you :)

image

@srini047
Copy link
Member Author

@FlorentLvr I have updated it. You can take a look and if you feel that there is lot of time in the pip install in the Naas lab, then let me update with Open in colab for better speed.

@FlorentLvr
Copy link
Contributor

@FlorentLvr I have updated it. You can take a look and if you feel that there is lot of time in the pip install in the Naas lab, then let me update with Open in colab for better speed.

Hey @srini047, I've reviewed your work and noticed that there isn't an example PDF link provided. Could you please include a working PDF URL for reference? You might consider adding a step to download it on Naas. Let me know if you have any questions 🙏

@jravenel
Copy link
Contributor

@srini047 @FlorentLvr are we done with this one? We were talking about making a video with @srini047 this friday. Just want to make sure it's ready for prime time.

@srini047
Copy link
Member Author

@FlorentLvr I have updated the PDF URL and also added the Open in colab button just in case it sometimes(initially) takes a lot of time to load in Naas.

@jravenel Sure I will be ready by then.

@jravenel
Copy link
Contributor

So are we going to shoot the video on naas since you have the thing setup now?

@srini047
Copy link
Member Author

So are we going to shoot the video on naas since you have the thing setup now?

Yes all set from my end.

@FlorentLvr
Copy link
Contributor

@srini047, i have added the weviate API key to make the notebook work and it's good now. Can you please try on your side?

I attempted to use the notebook with your PDF and another one from Tesla's results on the notebook itself, but the results didn't seem accurate. Could you provide an example where it worked well?

@srini047
Copy link
Member Author

srini047 commented Aug 1, 2023

@FlorentLvr I get an error when I actually run it.
image

Can you give this url a try from your end by the time let's fix this error.

@srini047
Copy link
Member Author

srini047 commented Aug 1, 2023

@FlorentLvr I get an error when I actually run it. image

Can you give this url a try from your end by the time let's fix this error.

Also for me the kernel dies when I run the Store the embeddings cell. Is that the same case for you too?

@FlorentLvr FlorentLvr merged commit 62a23a4 into master Sep 27, 2023
5 checks passed
@FlorentLvr FlorentLvr deleted the 1893-langchain-vector-search-on-the-pdf-using-langchain-abstraction branch September 27, 2023 12:38
@github-actions
Copy link

The template is now available on the master branch on this link:
https://github.com/jupyter-naas/awesome-notebooks/blob/master/LangChain/LangChain_Vector_Search_on_PDF.ipynb

@github-actions
Copy link

Thank you for your contribution @srini047, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

FlorentLvr.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request templates maintainer To be prioritize for notebook templates maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Langchain - Vector search on the PDF using langchain abstraction
4 participants