Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the certificate name generated on PR merge #2265

Merged

Conversation

srini047
Copy link
Member

@srini047 srini047 commented Oct 6, 2023

Fixes

This PR resolves #2264

What does this PR do?

Fix the certificate template name issue which replaces the actor with the author of the PR in the certificate workflow.

@srini047 srini047 added the bug Something isn't working label Oct 6, 2023
@srini047 srini047 requested a review from FlorentLvr October 6, 2023 18:47
@srini047 srini047 linked an issue Oct 6, 2023 that may be closed by this pull request
@FlorentLvr FlorentLvr merged commit 0dd5a19 into master Oct 7, 2023
5 checks passed
@FlorentLvr FlorentLvr deleted the 2264-fix-cicd-workflow-generate-certificate-template branch October 7, 2023 07:38
@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Thank you for your contribution @srini047, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

srini047.png

@srini047 srini047 self-assigned this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI/CD workflow: Generate certificate template
2 participants