Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2257 google sheets create new sheet #2331

Merged
merged 6 commits into from
Nov 5, 2023

Conversation

MSaiKiran9
Copy link
Contributor

Fixes

This PR resolves #2257

What does this PR do?

(Provide a description of what this PR does and why it's needed.)
It'll create a new google sheet and can share with people.

@MSaiKiran9 MSaiKiran9 requested a review from FlorentLvr October 20, 2023 12:36
@FlorentLvr FlorentLvr added enhancement New feature or request hacktoberfest Issues for hacktoberfest labels Oct 25, 2023
@MSaiKiran9
Copy link
Contributor Author

Hi @FlorentLvr can you see if it's good to go ?

@FlorentLvr FlorentLvr requested review from srini047 and removed request for FlorentLvr October 31, 2023 16:32
srini047
srini047 previously approved these changes Oct 31, 2023
Copy link
Member

@srini047 srini047 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀
@FlorentLvr

@FlorentLvr FlorentLvr dismissed srini047’s stale review October 31, 2023 18:07

I was not able to create a new sheet following the notebook

@FlorentLvr
Copy link
Contributor

@MSaiKiran9, I was not able to follow your procedure. I did not really understand what I had to do so to guid you I create a another notebook that creates a new spreadsheet from a spreadsheet name. Can you have a look and try to adapt your notebook to the one I did to make sure I can test yours?
Thanks you!

The notebook is: Google_Sheets_Create_new_sheet_from_spreadsheet_name.ipynb

@MSaiKiran9
Copy link
Contributor Author

MSaiKiran9 commented Nov 1, 2023

Hi @FlorentLvr , thankyou for your review . As you can see from this image
image . I used the naas secret to store the credentials object . I was able to produce a sheet , share the sheet with a person's mail and it's link using the above sheet , but if you think it's not readable I can edit the sheet further .

@FlorentLvr
Copy link
Contributor

Hi @FlorentLvr , thankyou for your review . As you can see from this image image . I used the naas secret to store the credentials object . I was able to produce a sheet , share the sheet with a person's mail and it's link using the above sheet , but if you think it's not readable I can edit the sheet further .

@MSaiKiran9, great but yes, it's not really easy to read it and understand the steps. Here is what I propose to improve:

  • Try to put all variables that the user needs to update. For example, the "SCOPES" is not a variable that we want the user to set but the api_key or spreadsheet ID are.
  • The model section should be about creating the new sheet.
  • The output section should be about displaying and accessing the result
    If you pull the branch you will access my notebook that might guid you to improve yours.
    Let me know if you have any others questions! 🙏

@MSaiKiran9
Copy link
Contributor Author

@FlorentLvr Sure I'm on it !

@MSaiKiran9
Copy link
Contributor Author

MSaiKiran9 commented Nov 4, 2023

Hi @FlorentLvr I updated the pr and wrote some edge cases like exception handling for the same & I've deleted the sheet you created for my reference . Here are the final refs of what the script is doing :
init_01
init_02

Hope it's consistent with the existing templates now .

@FlorentLvr FlorentLvr merged commit c736b97 into master Nov 5, 2023
@FlorentLvr FlorentLvr deleted the 2257-google-sheets-create-new-sheet branch November 5, 2023 16:45
@FlorentLvr FlorentLvr added the hacktoberfest-accepted Valid PRs for hacktoberfest label Nov 5, 2023
Copy link

github-actions bot commented Nov 5, 2023

The template is now available on the master branch on this link:
https://github.com/jupyter-naas/awesome-notebooks/blob/master/Sheets/Google_Sheets_Create_new_sheet.ipynb

Copy link

github-actions bot commented Nov 5, 2023

Thank you for your contribution @MSaiKiran9, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

MSaiKiran9.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Issues for hacktoberfest hacktoberfest-accepted Valid PRs for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sheets - Create new sheet
3 participants