Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Google Sheets - List sheets from spreadsheet #2346

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

FlorentLvr
Copy link
Contributor

This PR resolves #2345

@FlorentLvr FlorentLvr self-assigned this Oct 31, 2023
@FlorentLvr FlorentLvr added enhancement New feature or request hacktoberfest Issues for hacktoberfest labels Oct 31, 2023
@FlorentLvr FlorentLvr assigned MSaiKiran9 and unassigned FlorentLvr Nov 6, 2023
@MSaiKiran9
Copy link
Contributor

Hi @FlorentLvr , I changed the flow to console based, as the browser-based auth and redirection is not capturing the redirection as intended. Here is the demo result:
image

@FlorentLvr
Copy link
Contributor Author

Hi @FlorentLvr , I changed the flow to console based, as the browser-based auth and redirection is not capturing the redirection as intended. Here is the demo result: image

@MSaiKiran9, I am not sure to understand but could you please rework this notebook to be presented the same as the "Create new sheet" using a service account? This will be easier to understand if we use the same method 🙏 let me know if you have any doubts.

@MSaiKiran9
Copy link
Contributor

@FlorentLvr Above code is using Oauth2 for auth and I just changed the browser based auth & redirection to console based, it will ask for key to authenticate in the notebook (console based), after user confirms to trust the source in a new tab. But sure, I can make it consistent with the existing templates.

@MSaiKiran9
Copy link
Contributor

@FlorentLvr done

@FlorentLvr
Copy link
Contributor Author

@FlorentLvr done

@MSaiKiran9, amazing! It's working perfectly :)

@FlorentLvr FlorentLvr merged commit 6fea4a0 into master Nov 8, 2023
5 checks passed
@FlorentLvr FlorentLvr deleted the 2345-google-sheets-list-sheets-from-spreadsheet branch November 8, 2023 13:59
Copy link

github-actions bot commented Nov 8, 2023

The template is now available on the master branch on this link:
https://github.com/jupyter-naas/awesome-notebooks/blob/master/Sheets/Google_Sheets_List_sheets_from_spreadsheet.ipynb

Copy link

github-actions bot commented Nov 8, 2023

Thank you for your contribution @FlorentLvr, your PR has been merged into the master branch of awesome-notebook.
Here is the contribution certificate you can share on social media so everybody knows how awesome you are 🤙🌎.
Spread the #opensource love 💚

FlorentLvr.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Issues for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google Sheets - List sheets from spreadsheet
2 participants