Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naas asset api notebook #2533

Conversation

l-loic
Copy link
Contributor

@l-loic l-loic commented Jun 5, 2024

Fixes

This PR resolves #2524

What does this PR do?

Notebook for Naas Asset API

@l-loic l-loic requested review from Dr0p42 and FlorentLvr June 5, 2024 09:59
@l-loic l-loic self-assigned this Jun 5, 2024
@l-loic l-loic linked an issue Jun 5, 2024 that may be closed by this pull request
Copy link

gitguardian bot commented Jun 5, 2024

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
3347580 Triggered GitHub Access Token 4bb2313 GitHub/GitHub_Get_commits_ranking_from_repository.ipynb View secret
11541006 Triggered Generic Password 6cef0a1 Naas API/Naas_API_Asset.ipynb View secret
11541006 Triggered Generic Password 6cef0a1 Naas API/Naas_API_Asset.ipynb View secret
11541006 Triggered Generic Password d59cf67 Naas API/Naas_API_Asset.ipynb View secret
11541006 Triggered Generic Password d59cf67 Naas API/Naas_API_Get_Asset.ipynb View secret
11541006 Triggered Generic Password d59cf67 Naas API/Naas_API_Update_Asset.ipynb View secret
11541006 Triggered Generic Password d59cf67 Naas API/Naas_API_Asset.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@l-loic
Copy link
Contributor Author

l-loic commented Jun 5, 2024

Besides this, we will deploy a quick fix on the API to get this working properly.

@FlorentLvr FlorentLvr merged commit abc4239 into master Jun 28, 2024
5 checks passed
@FlorentLvr FlorentLvr deleted the 2524-feat-create-notebooks-for-crud-operations-using-naas-python-for-assets branch June 28, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Create notebooks for CRUD operations using naas-python for assets
2 participants