Change notebook code cell stream output schema #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
force-pushed
the
output
branch
3 times, most recently
from
7521f2f to
8a53a1d
Compare
|
Do we agree on merging this PR? |
davidbrochart
force-pushed
the
output
branch
2 times, most recently
from
d82f058 to
a2bb094
Compare
|
Yeah, I think this is the right way to handle stream outputs. Great work, @davidbrochart! The code looks good. Would you mind adding unit tests to cover this case? Or open an issue to add unit tests in a follow-up PR. |
|
Yes, I'll add tests in this PR. |
davidbrochart
force-pushed
the
output
branch
4 times, most recently
from
fb5298c to
91b2f56
Compare
Zsailer
approved these changes
Jun 7, 2024
|
Thanks, @davidbrochart! LGTM! |
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200.