Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate geoportal extensions leaflet #1042

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

HaudinFlorence
Copy link
Contributor

@HaudinFlorence HaudinFlorence commented Aug 22, 2022

Integrate the controls of the geoportal extensions leaflet. This includes :

  • GeoportalLayerSwitcher: a control to switch between different tile layers
  • GeoportalSearchEngine: a control to locate an address, a city
  • GeoportalRoute : a control to calculate itineraries (by car or by walking)
  • GeorportalMousePosition : a control to get the coordinates of a position on a map
  • GeoportalElevationPath : a control to plot the altimetric profile along a given itinerary
  • GeoportalIsocurve: a control to determine an aera around a position covering a given distance or a duration given a locomotion mean (by car or by walking)
  • GeoportalReverseGeocode: a control to get the adress or the parcel on a given selected place on a map

@HaudinFlorence HaudinFlorence marked this pull request as draft August 22, 2022 16:55
examples/Geoportal.ipynb Outdated Show resolved Hide resolved
examples/Geoportal.ipynb Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
js/src/layers/Geoportal.js Outdated Show resolved Hide resolved
js/src/layers/Geoportal.js Outdated Show resolved Hide resolved
Copy link
Member

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these layers be part of https://github.com/geopandas/xyzservices?

ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
examples/Geoportal.ipynb Outdated Show resolved Hide resolved
@HaudinFlorence
Copy link
Contributor Author

update galata reference

@HaudinFlorence HaudinFlorence force-pushed the integrate_geoportal_extensions_leaflet branch from d6b4259 to d2f4b69 Compare September 12, 2022 15:50
@HaudinFlorence
Copy link
Contributor Author

please update galata references

…s, and update the SearchEngine, MousePosition and Route controls.
@HaudinFlorence HaudinFlorence force-pushed the integrate_geoportal_extensions_leaflet branch from d2f4b69 to 9a580e8 Compare September 12, 2022 16:16
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
ipyleaflet/geoportal.py Outdated Show resolved Hide resolved
js/src/controls/GeoportalControls.js Show resolved Hide resolved
js/src/controls/GeoportalControls.js Show resolved Hide resolved
js/src/controls/GeoportalControls.js Outdated Show resolved Hide resolved
HaudinFlorence and others added 7 commits September 13, 2022 10:39
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
Co-authored-by: David Brochart <[email protected]>
@HaudinFlorence HaudinFlorence force-pushed the integrate_geoportal_extensions_leaflet branch from 6f8af2f to 8ed7407 Compare September 13, 2022 22:02
@HaudinFlorence HaudinFlorence force-pushed the integrate_geoportal_extensions_leaflet branch from 8ed7407 to 39dafb8 Compare September 13, 2022 22:18
@HaudinFlorence
Copy link
Contributor Author

please update galata references

@davidbrochart davidbrochart force-pushed the integrate_geoportal_extensions_leaflet branch from 231dacc to bc31e3c Compare September 14, 2022 09:52
@davidbrochart
Copy link
Member

I just rebased.

@HaudinFlorence HaudinFlorence force-pushed the integrate_geoportal_extensions_leaflet branch from bc31e3c to 3791744 Compare September 14, 2022 14:39
@HaudinFlorence
Copy link
Contributor Author

I just rebased.

Thanks !

@HaudinFlorence
Copy link
Contributor Author

HaudinFlorence commented Sep 16, 2022

I don't know how to fix the widgets rendering failing tests.

@HaudinFlorence HaudinFlorence marked this pull request as ready for review September 16, 2022 12:26
@HaudinFlorence
Copy link
Contributor Author

Should these layers be part of https://github.com/geopandas/xyzservices?

There is a PR under review open to integrate the IGN tile layers in the providers of xyzservices : geopandas/xyzservices#126

@davidbrochart
Copy link
Member

I don't know of the fix the widgets rendering failing tests.

There might be a bug in the geoportal extension for leaflet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants