Add visibility to MarkerCluster #1150
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
requested changes
Dec 5, 2023
| 'change:opacity', | ||
| function () { | ||
| if (this.model.get('visible')) { | ||
| document.querySelector('.test-icon').style.opacity = |
There was a problem hiding this comment.
This would not work if you have multiple marker clusters on the map and want to hide one and not the other. Hiding one would hide the other and that's unfortunately not what you want.
Comment on lines
+79
to
+81
| this.obj = L.markerClusterGroup({ | ||
| disableClusteringAtZoom: options['disableClusteringAtZoom'], | ||
| maxClusterRadius: options['maxClusterRadius'], |
There was a problem hiding this comment.
Instead of passing options manually you can unroll all of them with the following
Suggested change
| this.obj = L.markerClusterGroup({ | |
| disableClusteringAtZoom: options['disableClusteringAtZoom'], | |
| maxClusterRadius: options['maxClusterRadius'], | |
| this.obj = L.markerClusterGroup({ | |
| ...options, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.