Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken, deprecated nbextension enable from installation docs #1200

Merged
merged 1 commit into from
May 29, 2024

Conversation

minrk
Copy link
Contributor

@minrk minrk commented May 29, 2024

install docs still suggest

jupyter nbextension enable --py --sys-prefix ipyleaflet

which doesn't work anymore because nbextension methods moved to jupyter_leaflet without deprecation in #1189. It's unclear from #1189 whether breaking the nbextension name was intentional.

xref #1195

ipyleaflet package is no longer an nbextension, jupyter_leaflet is
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This is something we missed when splitting the ipyleaflet package in two

@martinRenou martinRenou merged commit ee2bdb1 into jupyter-widgets:master May 29, 2024
3 of 4 checks passed
@minrk minrk deleted the undoc-nbextension branch May 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants