Use proper assertion. #391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An "AssertionError" message is not that useful, at least here you will see that this is because the object passed in is not a coroutine...
davidbrochart
suggested changes
Jan 30, 2024
| @@ -144,8 +144,7 @@ def run_sync(coro: Callable[..., Awaitable[T]]) -> Callable[..., T]: | |||
| Whatever the coroutine-function returns. | |||
| """ | |||
|
|
|||
| if not inspect.iscoroutinefunction(coro): | |||
| raise AssertionError | |||
| assert inspect.iscoroutinefunction(coro) | |||
There was a problem hiding this comment.
Python's optimize mode will ignore assert statements.
Suggested change
| assert inspect.iscoroutinefunction(coro) | |
| if not inspect.iscoroutinefunction(coro): | |
| raise AssertionError(f"Not a coroutine function: {coro}") |
There was a problem hiding this comment.
👎 This should never happen anyway, if someone pass invalid values while in optimized mode they likely do not want to pay the cost of assert.
Plus below it's also doing wrapped.__doc__ = coro.__doc__ which also make no sens in optimized mode.
If you want to raise something in an if like that, then it should be a TypeError or ValueError, not an assertion.
There was a problem hiding this comment.
Ping on this. Failure seem unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An "AssertionError" message is not that useful, at least here you will see that this is because the object passed in is not a coroutine...