Improve compatibility with patched python-json-logger on py3.12+ #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discard the `taskName` field from event capsule, to preserve compatibility both with current python-json-logger versions, and with versions containing the Python 3.12 fix from madzak/python-json-logger#188 that removes the reserved `taskName` field.
for more information, see https://pre-commit.ci
Zsailer
approved these changes
Nov 4, 2024
|
LGTM. Thanks! |
|
Taking care of in #103; with a bunch of other things; thanks. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discard the
taskNamefield from event capsule, to preserve compatibility both with current python-json-logger versions, and with versions containing the Python 3.12 fixfrom madzak/python-json-logger#188 that removes the reserved
taskNamefield.