Fix jquery and element var #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_jquery_and_element_var
branch
from
c8e1724
to
5966762
Compare
eric-wieser
reviewed
Dec 13, 2019
| <script type="text/javascript"> | ||
| var element_id = '#{{ div_id }}'; | ||
| var element = $('#{{ div_id }}'); |
There was a problem hiding this comment.
I was under the impression that jupyter added this automatically as part of the script below. I'll try to confirm that by running this branch locally
There was a problem hiding this comment.
that would be great if you could test it. But this part was only for widgets, for JS it was still correct.
There was a problem hiding this comment.
Ah, I sadly have no experience (yet) with widgets
MSeal
approved these changes
Dec 18, 2019
There was a problem hiding this comment.
Thanks for getting this change in @maartenbreddels ! I'll post on the original issue threads to ask people to try testing the change out to see if it resolves the issue smoothly for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1148 and alternative to #1149.
jQuery support was removed in #1056 based on what we've done with voila. However, since we now have the two template (classic and lab) it makes sense that classic stays as compatible as it is with the classical notebook.
Therefore I've restored the jQuery library, and made the template exposes the
elementvariable again (used for js library/code).However, we want to get rid of jQuery, so in the lab template, we simply point the
elementvariable to the DOM Node, which has an API similar, meaning the example library mentioned in #1149 works with both the classical and lab template.The original issue in #1148 was solved by removing the unnecessary div element, and point
elementto the same DOM element as what would happen in the classical notebook.