Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a proper warning when a name is not found in a module #281

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

asmeurer
Copy link
Collaborator

@asmeurer asmeurer commented Sep 7, 2023

Closes #278

Let me know if this fix is OK. I had to add the log object to the DFSCollector class.

I haven't tried to update the scipy config as suggested in the issue. If we do that we need to make sure the docs all still get generated correctly. SciPy does a lot of weird dynamic stuff with its modules using module-level __dir__ and __getattr__.

@asmeurer asmeurer temporarily deployed to vercel-deployment September 7, 2023 21:30 — with GitHub Actions Inactive
@Carreau
Copy link
Member

Carreau commented Sep 12, 2023

Thanks !

@Carreau Carreau merged commit 93fb951 into jupyter:main Sep 12, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and remove SciPy workaround.
2 participants